]> dgit.raspbian.org Git - gnome-shell.git/commit
folderIcon: Move app icon loading to FolderView
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Sat, 29 Jun 2019 15:58:26 +0000 (12:58 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Tue, 6 Aug 2019 00:19:24 +0000 (21:19 -0300)
commit4d23c120281a5f66e694e021e277b3cf79940f19
treec96dba57fe24d220b6b4ba3ba737e46b226c7b81
parent476816732ff1a998a391a0d42dd8e0857d18591b
folderIcon: Move app icon loading to FolderView

Future patches will diff the old and new icons of views, in order to
animate them when necessary (e.g. adding an app icon to a folder, or
from a folder back to the app grid). In order to do that, all views
must be streamlined in how they load app icons.

Currently, FrequentView and AllView are already following the behavior
expected by BaseAppView, but FolderView isn't. Its icons are loaded by
FolderIcon, and FolderView doesn't implement BaseView._loadApps(),
which makes it impossible to diff old and new apps.

Move the app icon loading routine from FolderIcon to FolderView, by
implementing the _loadApps() method.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/645
js/ui/appDisplay.js